[Devtools] Fix DevTools hook indexing for useSyncExternalStore#34843
Closed
Biki-das wants to merge 1 commit intofacebook:mainfrom
Closed
[Devtools] Fix DevTools hook indexing for useSyncExternalStore#34843Biki-das wants to merge 1 commit intofacebook:mainfrom
Biki-das wants to merge 1 commit intofacebook:mainfrom
Conversation
useSyncExternalStore creates two internal hooks namely mountEffect & pushSimpleEffect, but should be reported as a single hook in DevTools. Skip internal hooks when calculating indices so the profiler shows the correct hook that triggered the render
Contributor
Author
|
cc @hoxyq looking forward to your thoughts. |
Contributor
|
Duplicate of #34547. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use
useSyncExternalStorehook , in a component and we try to profile the same, the hook count makes an additional count, say for example like in the below code, which i ran in thedevtools shelltest appwhen ran, the
why did it rendershows hook count as3, which is kind of wrong, as it should be rather2in this case. Below are the screen recording observation onafter&beforethe fixesBefore fixes
Screen.Recording.2025-10-11.at.11.26.17.PM.mov
After fixes
Screen.Recording.2025-10-11.at.11.29.41.PM.mov
As i went deep to search for the internal implementation for the

useSyncExternalStore, which is belowhttps://github.com/facebook/react/blob/main/packages/react-reconciler/src/ReactFiberHooks.js#L1634, if observed closely it calls two hooks internally, so internal implementation it is fine, but for the general profiler count, it should be a single hook